Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying pip cache dependencies inline in the yaml #351

Closed
ben-spiller opened this issue Mar 9, 2022 · 3 comments
Closed

Allow specifying pip cache dependencies inline in the yaml #351

ben-spiller opened this issue Mar 9, 2022 · 3 comments
Labels
feature request New feature or request to improve the current logic

Comments

@ben-spiller
Copy link

Description:
The new functionality to take care of caching dependencies is great. However I'd love to be able to specify the versions of Python third parties in-line in my yaml rather than in a separate requirements.txt file.

For example:

  - uses: actions/setup-python@v2
    with:
      python-version: 3.10
      # Enabled caching of dependencies
      cache: pip
      cache-dependencies: |
          pysys==2.0 
          coverage==3.5

Justification:
For non-Python repos that just happen to use Python, having a requirements.txt wouldn't be normal. More importantly, it increases clarity to see all the third party versions in one place - makes it easy to check and update your GH actions versions at the same time as the Python dependencies.

Implementation should be very easy - just write out the "cache-dependencies" string to a file and pass it to "cache-dependency-path".

Are you willing to submit a PR?
Not able to right now

@ben-spiller ben-spiller added feature request New feature or request to improve the current logic needs triage labels Mar 9, 2022
@ben-spiller ben-spiller changed the title Allow specifying pip cache inline in the yaml Allow specifying pip cache dependencies inline in the yaml Mar 9, 2022
@marko-zivic-93
Copy link
Contributor

Hello @ben-spiller
Thank you for your feature request.
We will inspect this potential feature and the benefits it could provide and will come back to you with our decision.

@marko-zivic-93
Copy link
Contributor

marko-zivic-93 commented Mar 29, 2022

Hello @ben-spiller
According to our ADR we will not pursue creating custom solutions of this type.
If you wish to add some customization to the existing functionalities, please use the action called actions/cache.
Thank you for your report once again!

@solodon4
Copy link

I need this feature too. How many votes do you need before you realize you need to adjust your ADR (whatever that means)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants