-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cache-dependency-paths outside the current directory #361
Comments
I'm currently working around this by coping the requirements file into a temporary directory within the working directory and then referencing that, instead of the original. This doesn't feel like a great solution though as it ends up polluting the target repo's working copy. |
Hello @PeterJCLaw. Thank you for your report. Could you please provide a public repository to reproduce the issue ? |
Hello @PeterJCLaw. Actually, I think the root cause of the issue in the toolkit/glob package. The hashFiles function tries to compare if the passed directory matches with GITHUB_WORKSPACE. The composite action's directory and checkout project's directory don't match, that is why if does hash the file and the actions setup-python throws an error. |
Thanks for your replies.
I've raised actions/toolkit#1035 for the underlying issue. |
Hello @PeterJCLaw. For now I'm going to close the pull request because the root cause of the issue comes from the toolkit repository. If you have any concerns feel free to ping us. |
https://github.blog/changelog/2021-11-23-github-actions-setup-python-now-supports-dependency-caching/ UPD: hmm it doesn't seem to work, complains that requirements.txt is missing this might be relevant... actions/setup-python#361
@dmitry-shibanov would you be open to reopening this issue? It looks like |
Hello @PeterJCLaw. In this case I'm coming to reopen the issue to investigate it one more time. edit: Sorry for edit in the first glance I thought it was a pull request. |
@dmitry-shibanov we also got hit by this one, any news whether this can be addressed now, that there is a new parameter in toolkit available? |
I'm also hit by this issue, I guess this line is quite common:
|
@dmitry-shibanov any progress on that? |
Description:
I'm building a composite Action which uses
actions/setup-python
internally. When specifying therequirements.txt
from the action setting up Python fails, though I thiiink I'm passing the right values.Here's what I've got:
Here's the error I get:
sr2022-comp
is the repo I'm using to test the action,srcomp-validate-action
is the action.My specific use-case only has a couple of dependencies so #351 would likely work as a fix, though I can imagine that a more complex scenario would want this to work.
Platform: Ubuntu
The text was updated successfully, but these errors were encountered: