-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct Poetry config when collecting Poetry projects #447
Merged
Commits on Dec 9, 2022
-
Use correct Poetry config when collecting Poetry projects
When collecting Poetry projects for caching, a '**/poetry.lock' glob is used. However, in order to process the Poetry configuration, the "poetry" command is run from the repo's root directory; this causes Poetry to return an invalid configuration when there is a Poetry project inside an inner directory. Instead of running a single Poetry command, glob for the same pattern, and run a Poetry command for every discovered project.
Configuration menu - View commit details
-
Copy full SHA for 748f3e6 - Browse repository at this point
Copy the full SHA 748f3e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 157f5da - Browse repository at this point
Copy the full SHA 157f5daView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc45b1e - Browse repository at this point
Copy the full SHA dc45b1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f350528 - Browse repository at this point
Copy the full SHA f350528View commit details -
Configuration menu - View commit details
-
Copy full SHA for 727a4d2 - Browse repository at this point
Copy the full SHA 727a4d2View commit details -
tests/cache-restore: Do not look for dependency files outside
data
When the default dependency path is used for cache distributors, they are looking for the dependency file in the project's root (including the source code), which leads to tests taking a significant amount of time, especially on Windows runners. We thus hit sporadic test failures. Change the test cases such that dependency files are always searched for inside of `__tests__/data`, ignoring the rest of the project.
Configuration menu - View commit details
-
Copy full SHA for 95696f7 - Browse repository at this point
Copy the full SHA 95696f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb9c5ac - Browse repository at this point
Copy the full SHA bb9c5acView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc3992e - Browse repository at this point
Copy the full SHA bc3992eView commit details -
poetry: Run
poetry env use
only after cache is loadedThe virtualenv cache might contain invalid entries, such as virtualenvs built in previous, buggy versions of this action. The `poetry env use` command will recreate virtualenvs in case they are invalid, but it has to be run only *after* the cache is loaded. Refactor `CacheDistributor` a bit such that the validation (and possible recreation) of virtualenvs happens only after the cache is loaded.
Configuration menu - View commit details
-
Copy full SHA for 881ca6e - Browse repository at this point
Copy the full SHA 881ca6eView commit details
Commits on Dec 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b69ad35 - Browse repository at this point
Copy the full SHA b69ad35View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.