-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Add requested permissions #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it cannot be fun at all to do, but I think we should not present this as the required permissions and instead present this as the recommanded ones.
Then for each option, just below the default value, mention if this will require a specific permission(s).
It gives transparency and also security insights.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lastly, I think it's worth suggesting a version with all the possible permissions so that if people don't care about security and wish to don't bother with this they still can (better than saying: enable everything mate!).
Co-authored-by: Geoffrey Testelin <[email protected]>
Co-authored-by: Geoffrey Testelin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes
Context
Everybody knows which permissions are required for the action.
closes #491