Drop rails 5.0 and 5.1 support #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
drop_rails_50_and_51_support
branch
3 times, most recently
from
9423a00
to
f22ea60
Compare
|
Looks great thanks! We'll need to update the branch settings to only require the 52/60 CI builds. |
deivid-rodriguez
force-pushed
the
drop_rails_50_and_51_support
branch
2 times, most recently
from
3f23397
to
f37d527
Compare
Since they are no longer maintained by the Rails team.
Since it's now the same requirement for all supported Rails versions.
deivid-rodriguez
force-pushed
the
drop_rails_50_and_51_support
branch
from
f37d527
to
7903e9c
Compare
|
I updated the required checks, so this should be good to go now 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that since the release of Rails 6.0, the Rails core team has dropped support for Rails 5.0 and Rails 5.1. See https://rubyonrails.org/security/ or https://edgeguides.rubyonrails.org/maintenance_policy.html.
So we should follow their lead.