Fix streaming CSV export #6451
Merged
Fix streaming CSV export #6451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streaming was not working either in development (disable_streaming off) nor on production Heroku. Adding a Last-Modified header made it work. The problem would only manifest when using rack 2.2 or higher, and was caused by rack/rack#1416, where the `Rack::ETag` middleware changed it's behaviour to buffer the response and calculate an ETag digest even though the `Cache-Control: no-cache` header is set. This breaks the CSV streaming responses so to avoid that we use the hack outlined in rack/rack#1619 and set a Last-Modified header which triggers the `skip_caching?` condition in the `Rack::ETag` middleware. This credit of this commit message goes to alphagov/e-petitions@46413a7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streaming was not working either in development (disable_streaming off) nor on production Heroku. Adding a Last-Modified header made it work.
The problem would only manifest when using rack 2.2 or higher, and was caused by rack/rack#1416, where the
Rack::ETagmiddleware changed it's behaviour to buffer the response and calculate an ETag digest even though theCache-Control: no-cacheheader is set. This breaks the CSV streaming responses so to avoid that we use the hack outlined in rack/rack#1619 and set a Last-Modified header which triggers theskip_caching?condition in theRack::ETagmiddleware.This credit of this commit message goes to alphagov/e-petitions@46413a7.
This PR supersedes #6363.