Add RuboCop RSpec #549
Merged
Add RuboCop RSpec #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
commented
Nov 1, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #549 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 17 17
Lines 460 460
=======================================
Hits 425 425
Misses 35 35 ☔ View full report in Codecov by Sentry. |
javierjulio
reviewed
Nov 1, 2023
tagliala
force-pushed
the
chore/add-rubocop-rspec
branch
4 times, most recently
from
b82b383
to
65de19e
Compare
Also include manual fixes: - Fixes some `RSpec/ExampleWording` where autocorrection failed - Fixes `RSpec/RepeatedDescription` offense
For this use case, `double` may work better than `instance_double` and `class_double` to cover use cases where active model is not present
Rename files where describe did not match the file name
Those cops can be configured, fixed, and enabled in a second stage if they are needed: - RSpec/DescribeMethod - RSpec/ExampleLength - RSpec/FilePath - RSpec/MultipleExpectations - RSpec/NestedGroups - RSpec/SpecFilePathFormat
tagliala
force-pushed
the
chore/add-rubocop-rspec
branch
from
65de19e
to
46f3b0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some fixes that could be backported to master, but probably it is not worth it
I will comment on a spec that I can't properly understand and that probably should be improved since now the minimum required ruby version is 2.7