Drop support for Ruby 2.5 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandroperea
force-pushed
the
drop-support-for-ruby-2.5
branch
from
49d66c5
to
f806fcf
Compare
|
I'm usually very agressive with dropping Ruby support but if we do here should not we do in all the other active admin repos? |
|
Yes, that would be the plan. |
javierjulio
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
We already started to remove Ruby 2.5 support in other ActiveAdmin org gems, in fact @alejandroperea contributed that same change in activeadmin/activeadmin#7236 (thanks!)
@alejandroperea do you mind rebasing and pushing again?
alejandroperea
force-pushed
the
drop-support-for-ruby-2.5
branch
from
f806fcf
to
51fc0bf
Compare
|
@javierjulio Rebased! 😄 |
|
@alejandroperea awesome, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.5 arrived to EOL more than 8 months ago. I think we can remove it from the test matrix and drop the support.