Airwallex: QA round 2 #4377
Merged
Airwallex: QA round 2 #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmcclain
approved these changes
Apr 4, 2022
| post[:request_id] = options[:request_id] | ||
| post[:merchant_order_id] = options[:merchant_order_id] | ||
|
|
||
| response = commit(:setup, post) | ||
| raise ArgumentError.new(response.message) unless response.success? |
There was a problem hiding this comment.
This solution makes sense, and I see that you have added logic on Spreedly's end of the integration to handle this. I am curious whether you considered wrapping create_payment_intent in some logic to preempt the :sale call and return a failure response if this initial :setup call fails?
Basically I'm just wondering if there is a reason that raising an error is preferable to returning a failure response in cases where create_payment_intent fails?
dsmcclain
force-pushed
the
CE-2527-2534-2535-airwx-qa-2
branch
from
df2b6a8
to
8f3c32c
Compare
dsmcclain
force-pushed
the
CE-2527-2534-2535-airwx-qa-2
branch
from
8f3c32c
to
7b4a0e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit:
22 tests, 82 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
18 tests, 46 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Rubocop:
739 files inspected, no offenses detected