Simetrik: Fix integer and float types #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmcclain
suggested changes
Apr 25, 2022
| amount: { | ||
| currency: 'USD', | ||
| vat: 19 | ||
| } |
There was a problem hiding this comment.
big improvement considering we don't want customers to have to pass a rich object for amount 👍
rachelkirk
force-pushed
the
CE-2407_simetrik_update
branch
from
d6098d9
to
032d647
Compare
dsmcclain
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Nice work puzzling through this @rachelkirk. All tests are passing for me.
It would be nice if you update your PR description to indicate that the remote tests are currently passing on this branch.
Also don't forget a changelog entry.
Rubocop:
739 files inspected, no offenses detected
Unit:
5173 tests, 75674 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
12 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
CE-2407 This PR does some refactoring and updates some value types that were being passed incorrectly. The scrub method has also been updated. Remote Tests: 12 tests, 64 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: 12 tests, 83 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Local Tests: 5167 tests, 75646 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: 739 files inspected, no offenses detected
rachelkirk
force-pushed
the
CE-2407_simetrik_update
branch
from
032d647
to
42a1553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CE-2407
This PR does some refactoring and updates some value types that were being passed incorrectly. The scrub method has also been updated.
Remote tests:
12 tests, 24 assertions, 0 failures, 8 errors, 0 pendings, 0 omissions, 0 notifications
33.3333% passed
Unit tests:
12 tests, 82 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed