Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monei: add cardholderName field #4409

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

dsmcclain
Copy link
Contributor

@dsmcclain dsmcclain commented Apr 29, 2022

Monei's sandbox does not care if this field gets passed or not, but its omission will cause failures in production.

This field can be found here in Monei's docs if you expand the paymentMethod object and the child card object.

CE-2562

Rubocop:
739 files inspected, no offenses detected

Unit:
5174 tests, 75676 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
25 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Monei's sandbox does not care if this field gets passed or not, but its
omission will cause failures in production.

CE-2562

Rubocop:
739 files inspected, no offenses detected

Unit:
5174 tests, 75676 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
25 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@dsmcclain dsmcclain requested a review from a team April 29, 2022 15:40
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dsmcclain dsmcclain merged commit cb01936 into master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants