Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rapyd: Pass Fields to refund and store #4449

Merged

Conversation

naashton
Copy link
Contributor

@naashton naashton commented Jun 8, 2022

Add ewallet to refund and metadata, ewallet, and
payment_fields to store transactions.

CE-2606

Unit: 18 tests, 79 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote: 27 tests, 79 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@naashton naashton requested a review from a team June 8, 2022 15:00
Copy link
Contributor

@drkjc drkjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naashton Looks good and tests pass. I'm approving but also wanted to point out that the payment_id wasn't added as an option in the test files.

@naashton naashton force-pushed the CE-2606-pass_fields_on_store_refund branch from c366980 to 13b7f27 Compare June 8, 2022 17:42
Add `ewallet` to `refund` and `metadata`, `ewallet`, and
`payment_fields` to `store` transactions.

CE-2606

Unit: 18 tests, 79 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote: 27 tests, 79 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@naashton naashton force-pushed the CE-2606-pass_fields_on_store_refund branch from 13b7f27 to 3a2081e Compare June 8, 2022 17:44
@naashton naashton merged commit 3a2081e into activemerchant:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants