Shift4: Code Refactoring #4469
Merged
Shift4: Code Refactoring #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajawadmirza
force-pushed
the
refactor_shift4
branch
2 times, most recently
from
7064ead
to
18918d1
Compare
naashton
approved these changes
Jun 23, 2022
ajawadmirza
force-pushed
the
refactor_shift4
branch
from
18918d1
to
1c71a12
Compare
ajawadmirza
force-pushed
the
refactor_shift4
branch
from
1c71a12
to
91cd644
Compare
naashton
approved these changes
Jun 23, 2022
Refactored gateway identifier as per the technical document, updated remote tests to remove redundancy, refactored gateway file to remove unwanted fields. SER Remote: 11 tests, 29 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 746 files inspected, no offenses detected Unit: 5229 tests, 75978 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
ajawadmirza
force-pushed
the
refactor_shift4
branch
from
91cd644
to
f92280a
Compare
naashton
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored gateway as per the technical document, updated remote tests to remove redundancy, refactored gateway file to remove unwanted fields.
SER
Remote:
11 tests, 29 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Rubocop:
746 files inspected, no offenses detected
Unit:
5229 tests, 75978 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed