Airwallex: change timestamps to uuids and remove _setup suffix from merchant_order_id
#4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merchant_order_id SER-65 Unit: 5243 tests, 76069 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 746 files inspected, no offenses detected Remote: Loaded suite test/remote/gateways/remote_airwallex_test 26 tests, 61 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airwallex has requested that we default to a uuid instead of a timestamp for these fields.
They have also requested that we remove the
_setupsuffix from themerchant_order_idfield, as that field does not need to be unique per transaction and will be used by customers during reconciliation.The
_setupsuffix remains for therequest_idfield, because that field must be unique for every request, so the suffix is useful for differentiating two separate but associated requests (e.g. acreate_payment_intentfollowed by a subsequentsale).SER-65
Unit:
5243 tests, 76069 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Rubocop:
746 files inspected, no offenses detected
Remote:
Loaded suite test/remote/gateways/remote_airwallex_test
26 tests, 61 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed