-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Braintree Blue: Partial capture #4515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but I think we should add remote tests for partial capture.
@tatsianaclifton I didn't add a remote test for partial capture because the Braintree docs mentioned it is only available for Paypal and Venmo transactions and I don't think those auths are added in AM yet. Are they in AM? |
PayPal and Venmo should work for |
@tatsianaclifton good to know! I'll look into that later and see if it works |
I think all you would need is a Venmo/ Paypal nonce? Those are available here for testing: https://developer.paypal.com/braintree/docs/reference/general/testing#nonces-representing-alternative-payment-methods |
856f881
to
8042e3c
Compare
@tatsianaclifton @molbrown thanks for those resources! I was able to add a successful partial capture remote test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Braintree blue can support partial captures for certain types of transactions. This commit adds logic to handle partial capture logic if the `partial_capture` field is passed down. Test Summary Local: 5269 tests, 76156 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 746 files inspected, no offenses detected Unit: 92 tests, 204 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 99 tests, 538 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
8042e3c
to
e011f28
Compare
Braintree blue can support partial captures for certain
types of transactions. This commit adds logic to handle partial capture
logic if the
partial_capture
field is passed down.Test Summary
Local:
5269 tests, 76156 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
746 files inspected, no offenses detected
Unit:
92 tests, 204 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
98 tests, 530 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed