Stripe PI: add options for setup intent #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BritneyS
reviewed
Aug 9, 2022
aenand
force-pushed
the
add_options_to_retrieve_setup_intent
branch
from
3606da6
to
446508e
Compare
aenand
force-pushed
the
add_options_to_retrieve_setup_intent
branch
from
446508e
to
054ab47
Compare
ECS-2548 The Stripe PI gateway setup intent flow does not include an optional options hash during the retrieve_setup_intent method. This prohibits someone using Stripe connect from completing this flow. Test Summary Local: 5273 tests, 76175 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 746 files inspected, no offenses detected Unit: 39 tests, 207 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 78 tests, 371 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
aenand
force-pushed
the
add_options_to_retrieve_setup_intent
branch
from
054ab47
to
4abfc3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECS-2548
The Stripe PI gateway setup intent flow does
not include an optional options hash during
the retrieve_setup_intent method. This
prohibits someone using Stripe connect
from completing this flow.
Test Summary
Local:
5273 tests, 76175 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
746 files inspected, no offenses detected
Unit:
39 tests, 207 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
78 tests, 371 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed