Worldpay: Update required_status_message and message_from methods
#4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I will probably defer to Marketplace Services team for final approval once this PR is not a draft anymore, but should the test expectations be changed for those 4 failing tests, since we've changed the logic of how the response message is created? |
rachelkirk
force-pushed
the
CER-18_worldpay_status_message
branch
from
d0d31c3
to
f0ff3db
Compare
therufs
approved these changes
Aug 11, 2022
CER-18 Updating the `required_status_message` method to only generate the AM response if using one of the actions called out in the method. The transaction types are all multi-response and use a combination of actions. Remote Tests: 100 tests, 412 assertions, 0 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications 99% passed100 tests, 392 assertions, 4 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications *The 1 error is also happening on master, may be related to recent Worldpay updates. Unit Tests: 104 tests, 613 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Local: 5274 tests, 76180 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
rachelkirk
force-pushed
the
CER-18_worldpay_status_message
branch
from
f0ff3db
to
ad8f634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CER-18
Updating the
required_status_messagemethod to only generate the AM response if using one of the actions called out in the method. The transaction types are all multi-response and use a combination of actions.Remote Tests:
100 tests, 392 assertions, 4 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications
95% passed
*4 failing tests are 3DS tests that hinge on that message being auto-generated. The message being auto-generated means that the transaction itself failed. When prying into the responses, for these tests
@success = false. The 1 error is also happening on master, may be related to recent Worldpay updates.Unit Tests:
104 tests, 613 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Local:
5274 tests, 76180 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed