Adyen: modify handling of countryCode for ACH #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelkirk
approved these changes
Aug 18, 2022
This change allows ACH transactions to fail with an Adyen error message instead of with a NoMethodError when no :country is present inside the :billing_address hash CER-151 LOCAL 5284 tests, 76224 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 746 files inspected, no offenses detected UNIT 95 tests, 482 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed REMOTE 125 tests, 445 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.6% passed
jcreiff
force-pushed
the
CER-151_adyen_ach_error
branch
from
24ac8de
to
1afa526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows ACH transactions to fail with an Adyen error message
instead of with a NoMethodError when no
:countryis present inside the:billing_addresshashCER-151
LOCAL
5284 tests, 76224 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
746 files inspected, no offenses detected
UNIT
95 tests, 482 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
REMOTE
125 tests, 445 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.6% passed