Rapyd: No force capture for ACH
#4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmcclain
approved these changes
Sep 2, 2022
| add_payment_fields(post, options) | ||
| add_payment_urls(post, options) | ||
| add_customer_id(post, options) | ||
| add_auth_purchase(post, money, payment, options) | ||
| post[:capture] = true if payment.is_a?(CreditCard) |
There was a problem hiding this comment.
The only thing I am wondering here is whether folks will be transacting on Rapyd with any other tokenized payment method type that is not a Check and not a CreditCard, and whether we might want capture: true in those cases?
Rapyd automatically settles ACH transactions at EOD and force-capturing. SER-284 Unit: 20 tests, 93 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 29 tests, 84 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
naashton
force-pushed
the
rapyd-ach-no-capture
branch
from
58ec3da
to
b7a487f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rapyd automatically settles ACH transactions at EOD and force-capturing.
SER-284
Unit: 20 tests, 93 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote: 29 tests, 84 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed