Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenPay: Update url endpoint #4573

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

ajawadmirza
Copy link
Contributor

Updated endpoint from .mx to .co along with slight change in error message for the declined transactions as returned by the gateway. Added unit test to verify that the correct url is being hit for the gateway.

SER-304

Unit:
5334 tests, 76512 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Rubocop:
749 files inspected, no offenses detected

Remote:
24 tests, 80 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 95.8333% passed

Copy link
Contributor

@curiousepic curiousepic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the extra fix

@curiousepic
Copy link
Contributor

@naashton could you handle merging? I'm hitting a git issue with Jawad's branch/fork

Updated endpoint from `.mx` to `.co` along with slight change in error message for the declined transactions as returned by the gateway. Added unit test to verify that the correct url is being hit for the gateway.

SER-304

Unit:
5334 tests, 76512 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Rubocop:
749 files inspected, no offenses detected

Remote:
24 tests, 80 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
95.8333% passed
@naashton naashton merged commit acb8b64 into activemerchant:master Sep 16, 2022
curiousepic added a commit that referenced this pull request Sep 22, 2022
curiousepic added a commit that referenced this pull request Sep 22, 2022
curiousepic added a commit that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants