Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adyen: Map Standard Error Codes #4593

Merged

Conversation

ajawadmirza
Copy link
Contributor

Added new error codes in mapping for STANDARD_ERROR_CODE so that for dispatch known_error_list can support passing of standard error codes instead of gateway error code numbers. Unit test for each failover errors are added as well.

SER-266

Unit:
5352 tests, 76613 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Rubocop:
750 files inspected, no offenses detected

Remote:
125 tests, 443 assertions, 4 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.8% passed

Added new error codes in mapping for `STANDARD_ERROR_CODE` so that for dispatch `known_error_list` can support passing of standard error codes instead of gateway error code numbers. Unit test for each failover errors are added as well.

SER-266

Unit:
5352 tests, 76613 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Rubocop:
750 files inspected, no offenses detected

Remote:
125 tests, 443 assertions, 4 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
96.8% passed
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@naashton naashton merged commit 8a53eb9 into activemerchant:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants