Reach: Fixing bug when using union pay card #4645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aims to fix an bug related with the way to handle not supported card brands. Finished in 130.664153 seconds. 25 tests, 66 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Finished in 35.408869 seconds. 5415 tests, 76945 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 152.93 tests/s, 2173.04 assertions/s Inspecting 756 files 756 files inspected, no offenses detected
naashton
reviewed
Dec 9, 2022
|
@naashton indeed this PR solves that issue, the problem was that Union pay was not mapped and the PaymentMethod param end-up being empty, so I added union pay as an options and an Argument Error in case that something like alelo,sodexo,etc. gets there. |
naashton
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change aims to fix an bug related with the way to handle not supported card brands.
Tests:
Finished in 130.664153 seconds.
25 tests, 66 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Finished in 35.408869 seconds.
5415 tests, 76945 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
152.93 tests/s, 2173.04 assertions/s
Inspecting 756 files
756 files inspected, no offenses detected