Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braintree: return additional processor response #4653

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

jcreiff
Copy link
Contributor

@jcreiff jcreiff commented Dec 21, 2022

Adds the additional_processor_response to the transaction hash for unsuccessful transactions

CER-284

LOCAL
5414 tests, 76942 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

756 files inspected, no offenses detected

REMOTE
100 tests, 491 assertions, 4 failures, 4 errors, 0 pendings, 0 omissions, 0 notifications 92% passed

These failures/errors are present on the master branch as well

@jcreiff jcreiff requested a review from a team December 21, 2022 18:07
Copy link
Contributor

@rachelkirk rachelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

def additional_processor_response_from_result(result)
result.transaction&.additional_processor_response
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Adds the `additional_processor_response` to the transaction hash for unsuccessful transactions

CER-284
LOCAL
5414 tests, 76942 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

756 files inspected, no offenses detected

REMOTE
100 tests, 491 assertions, 4 failures, 4 errors, 0 pendings, 0 omissions, 0 notifications
92% passed

These failures/errors are present on the master branch as well
@jcreiff jcreiff force-pushed the CER-284_braintree_additionalProcessorResponse branch from 0e6f5d3 to b91b2bd Compare January 9, 2023 22:13
@jcreiff jcreiff merged commit b91b2bd into master Jan 9, 2023
@jcreiff jcreiff deleted the CER-284_braintree_additionalProcessorResponse branch January 9, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants