Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalCollect: Add transaction inquire request #4669

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

almalee24
Copy link
Contributor

Get payment status by payment id.

Unit:
44 tests, 224 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote:
41 tests, 90 assertions, 11 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 73.1707% passed

@almalee24 almalee24 requested a review from a team January 6, 2023 15:42
@naashton
Copy link
Contributor

naashton commented Jan 9, 2023

Your changes look good, but I'm wondering if we should figure out why all of these remote tests are now failing?

@almalee24
Copy link
Contributor Author

Your changes look good, but I'm wondering if we should figure out why all of these remote tests are now failing?

I thinking it's because the global_collect_preprod credentials are expired. Which reminds me to look into getting new ones, will work on this now.

@naashton
Copy link
Contributor

naashton commented Jan 9, 2023

Ah yes, that looks to be the issue.

@almalee24
Copy link
Contributor Author

Ah yes, that looks to be the issue.

I've updated the global_collect_preprod credentials so you can test again with that. I only have one test failing for me now

Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for updating those credentials for this gateway.

🚢

Get payment status by payment id.

Unit:
44 tests, 224 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
41 tests, 108 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.561% passed
@almalee24 almalee24 force-pushed the global_connect_add_transaction_query branch from 8e816d8 to 9243823 Compare January 9, 2023 17:48
@almalee24 almalee24 merged commit 9243823 into master Jan 9, 2023
@almalee24 almalee24 deleted the global_connect_add_transaction_query branch January 9, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants