Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Canadian Institution Numbers #4687

Merged

Conversation

jcreiff
Copy link
Contributor

@jcreiff jcreiff commented Jan 26, 2023

Adds two additional valid Canadian Institution Numbers: 618, 842
https://en.wikipedia.org/wiki/Routing_number_(Canada)

CER-403

5439 tests, 77066 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

756 files inspected, no offenses detected

@jcreiff jcreiff requested a review from a team January 26, 2023 19:27
Copy link
Contributor

@rachelkirk rachelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, eh?!

Adds two additional valid Canadian Institution Numbers: 618, 842
https://en.wikipedia.org/wiki/Routing_number_(Canada)

CER-403

5439 tests, 77066 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

756 files inspected, no offenses detected
@jcreiff jcreiff force-pushed the CER-403_canadian_institution_numbers branch from 6b04b8c to 6fe9437 Compare January 30, 2023 15:43
@jcreiff jcreiff merged commit 2eb14a1 into activemerchant:master Jan 30, 2023
@jcreiff jcreiff deleted the CER-403_canadian_institution_numbers branch January 30, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants