Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CER-460 Add descriptor phone number to blue_snap #4717

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

yunnydang
Copy link
Contributor

Local:
5457 tests, 77095 assertions, 0 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications 99.6518% passed

Unit:
45 tests, 269 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote:
53 tests, 171 assertions, 9 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 83.0189% passed

@yunnydang yunnydang requested a review from a team February 27, 2023 20:07
@yunnydang yunnydang self-assigned this Feb 27, 2023
Copy link
Contributor

@jcreiff jcreiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I confirmed that the failing remote tests also fail on master and aren't related to this change 👍🏻

Local:
5457 tests, 77095 assertions, 0 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications
99.6518% passed

Unit:
45 tests, 269 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
53 tests, 171 assertions, 9 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
83.0189% passed
@yunnydang yunnydang merged commit 2daf48b into master Mar 1, 2023
@yunnydang yunnydang deleted the CER-460_add_gsf_blue_snap branch March 1, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants