Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cybersource: Add business rules for NT #4772

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

aenand
Copy link
Contributor

@aenand aenand commented May 5, 2023

ECS-2849

A previous commit from 2015 restricted the ability to pass business rules such as ignoreAVSResult and ignoreCVResult on API requests with NetworkTokenization cards. Merchants are now asking for this to be allowed on requests with payment methods such as NT/AP/GP and the remote tests seem to indicate we can add these fields for these types of payment methods.

Remote:
119 tests, 607 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.479% passed

@aenand aenand requested a review from a team May 5, 2023 15:41
@aenand
Copy link
Contributor Author

aenand commented May 5, 2023

Note for reviewers: These fields being passed will be covered by existing tests since those fields are in the options hash of the remote tests. Additionally the 3 failing tests are also failing on master

@aenand aenand force-pushed the ECS-2849_cybs_ignore_avs branch 4 times, most recently from c2d049a to 0c34108 Compare May 5, 2023 16:04
Copy link
Contributor

@BritneyS BritneyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make sense. A lot of opening up AP/GP PM options lately 🙂

ECS-2849

A previous commit from 2015 restricted the ability to pass
business rules such as `ignoreAVSResult` and `ignoreCVResult` on
API requests with NetworkTokenization cards. Merchants are now
asking for this to be allowed on requests with payment methods
such as NT/AP/GP and the remote tests seem to indicate we can
add these fields for these types of payment methods.

Remote CBYS SOAP:
119 tests, 607 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.479% passed
Remote CYBS Rest:
46 tests, 152 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@aenand aenand merged commit f2585c1 into master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants