Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required Ruby version #4823

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Update required Ruby version #4823

merged 2 commits into from
Jul 25, 2023

Conversation

almalee24
Copy link
Contributor

Updated required Ruby version to be 2.7 and Rubocop to 0.72.0.

All unit tests and rubocop:
5532 tests, 77501 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

@almalee24 almalee24 requested a review from a team July 3, 2023 17:11
@almalee24 almalee24 force-pushed the update_ruby_version branch 4 times, most recently from f06bac1 to 92ca208 Compare July 5, 2023 20:46
@BritneyS
Copy link
Contributor

BritneyS commented Jul 6, 2023

Will this get you where you need to be to upgrade the braintree gem or will you eventually need to bump it to Ruby 3?

@almalee24
Copy link
Contributor Author

almalee24 commented Jul 6, 2023 •
edited
Loading

Will this get you where you need to be to upgrade the braintree gem or will you eventually need to bump it to Ruby 3?

Yeah 2.7 is enough for the braintree gem update. But I'll we'll eventually need to bump it to Ruby 3 since 2.7 is EOL

@aenand
Copy link
Contributor

aenand commented Jul 6, 2023

@almalee24 have you tried running Core's unit tests with this version of AM?

@activemerchant activemerchant deleted a comment from mexpadmar Jul 6, 2023
@almalee24
Copy link
Contributor Author

@almalee24 have you tried running Core's unit tests with this version of AM?

Yes, they ran successfully!

aenand
aenand approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@aenand aenand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@aenand
Copy link
Contributor

aenand commented Jul 17, 2023

@almalee24 did you add ruby 3 and 3.1 to the CI checks?

@almalee24
Copy link
Contributor Author

@almalee24 did you add ruby 3 and 3.1 to the CI checks?

Nope, they fail so I just kept 2.7. Ruby 3 & 3.1 will be for another ticket. This is just to unblock braintree gem update.

@almalee24 almalee24 force-pushed the update_ruby_version branch 2 times, most recently from da2c539 to 06cff2b Compare July 25, 2023 13:40
Alma Malambo added 2 commits July 25, 2023 08:53
Update required Ruby version
3b43529 
Updated required Ruby version to be 2.7 and Rubocop to 0.72.0.

All unit tests and rubocop:
5532 tests, 77501 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Release v1.134.0
3f45193
@almalee24 almalee24 merged commit 3f45193 into master Jul 25, 2023
5 checks passed
@almalee24 almalee24 deleted the update_ruby_version branch July 25, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aenand aenand aenand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@almalee24 @BritneyS @aenand