Borgun: Update authorization_from & message_from #4826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
force-pushed
the
update_borgun_authorization
branch
from
38a6a9d
to
1eb74d4
Compare
BritneyS
approved these changes
Jul 11, 2023
almalee24
force-pushed
the
update_borgun_authorization
branch
3 times, most recently
from
3bf0af4
to
c5bf1c0
Compare
I was able to get it fixed |
Update authorization_from to return nil if the transaction failed or it is a 3DS transaction. Update message_from to return ErrorMessage if present. Unit: 12 tests, 66 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 22 tests, 43 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 72.7273% passed
almalee24
force-pushed
the
update_borgun_authorization
branch
from
c5bf1c0
to
b135d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update authorization_from to return nil if the transaction failed or it is a 3DS transaction. Update message_from to return ErrorMessage if present.
Unit:
12 tests, 66 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote:
22 tests, 43 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 72.7273% passed