Authorize.NET: Update network token method #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
force-pushed
the
authorize_net_network_token
branch
2 times, most recently
from
885ae68
to
1c9e44f
Compare
aenand
reviewed
Aug 23, 2023
Yes, I've been talking to them directly about this. The |
BritneyS
reviewed
Aug 24, 2023
BritneyS
reviewed
Aug 25, 2023
| end | ||
| end | ||
| end | ||
|
|
||
| def add_market_type_device_type(xml, payment, options) | ||
| return if payment.is_a?(String) || card_brand(payment) == 'check' || card_brand(payment) == 'apple_pay' | ||
| return unless payment.is_a?(CreditCard) && !payment.is_a?(NetworkTokenizationCreditCard) |
There was a problem hiding this comment.
Suggested change
| return unless payment.is_a?(CreditCard) && !payment.is_a?(NetworkTokenizationCreditCard) | |
| return if payment.is_a?(NetworkTokenizationCreditCard) |
Is there a way to avoid the double negative here?
There was a problem hiding this comment.
I can split them in two different lines
almalee24
force-pushed
the
authorize_net_network_token
branch
from
1c9e44f
to
8c66260
Compare
BritneyS
approved these changes
Sep 7, 2023
almalee24
force-pushed
the
authorize_net_network_token
branch
from
8c66260
to
0ddc0eb
Compare
Update network token payment method to clarify what is being sent. Remote: 85 tests, 304 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 122 tests, 684 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
almalee24
force-pushed
the
authorize_net_network_token
branch
from
0ddc0eb
to
544806e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update network token payment method to clarify what is being sent.
Remote:
85 tests, 304 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Unit:
122 tests, 684 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed