Adding Oauth Response for access tokens #4869
Conversation
almalee24
force-pushed
the
oauth_response_on_gateways
branch
from
00612dc
to
0fbf623
Compare
lib/active_merchant/errors.rb
Outdated
| @@ -23,6 +23,12 @@ def initialize(response, message = nil) | |||
| end | |||
|
|
|||
| def to_s | |||
| if response.kind_of?(String) | |||
| return response if response.start_with?('Failed with') | |||
There was a problem hiding this comment.
As-is, an arbitrary String response that doesn't start with Failed with would say ActiveMerchant::OAuthResponseError: Failed with. Is that desirable?
There was a problem hiding this comment.
Yes exactly. I add this check because some gateways like Alelo check access_token method in commit so it would return ActiveMerchant::OAuthResponseError: Failed with Failed with.
There was a problem hiding this comment.
But wouldn't returning the the response string in that case be more informative?
There was a problem hiding this comment.
In the case I described the OAuthResponseError or maybe I'm not understanding what you trying to say
There was a problem hiding this comment.
I mean that error strings like An error happened would return ActiveMerchant::OAuthResponseError: Failed with and not fall to the general case ActiveMerchant::OAuthResponseError: Failed with An error happened. So I'm wondering if the if response.start_with?('Failed with') check is necessary, when it could read as ActiveMerchant::OAuthResponseError: An error happened without that check.
There was a problem hiding this comment.
Oh, if response is a string then it wouldn't be a ActiveMerchant::OAuthResponseError. If response was ActiveMerchant::OAuthResponseError the it would fall into the second statement, elsif response.respond_to?(:message).
almalee24
force-pushed
the
oauth_response_on_gateways
branch
2 times, most recently
from
7be8808
to
2f2b2be
Compare
almalee24
force-pushed
the
oauth_response_on_gateways
branch
from
2f2b2be
to
69d4ffc
Compare
Add new OAuth Response error handling to PayTrace, Quickbooks, Simetrik, Alelo, CheckoutV2 and Airwallex.
almalee24
force-pushed
the
oauth_response_on_gateways
branch
from
69d4ffc
to
3931adf
Compare
Add new OAuth Response error handling to PayTrace, Quickbooks, Simetrik, Alelo, CheckoutV2 and Airwallex.