-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rapyd: 3ds gateway specific #4876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinourain
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description ------------------------- This commit add a couple of test to be sure that we are sending the three_d_required field as a GSF in order to perform a 3DS gateway specific in Rapyd. Additional enable execute 3ds gateway specific when the execute_threed option is true. Unit test ------------------------- Finished in 0.076246 seconds. 27 tests, 140 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 354.12 tests/s, 1823.05 assertions/s Remote test ------------------------- Finished in 113.329864 seconds. 34 tests, 99 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed 0.30 tests/s, 0.86 assertions/s Rubocop ------------------------- 763 files inspected, no offenses detected
javierpedrozaing
force-pushed
the
SER-734_Rapyd_3ds_gateway_specific
branch
from
August 25, 2023 21:01
abda1e5
to
d69eda5
Compare
naashton
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
javierpedrozaing
pushed a commit
that referenced
this pull request
Sep 8, 2023
Description ------------------------- [SER-808](https://spreedly.atlassian.net/browse/SER-808) This commit validate if the cvv in order to don't allow send empty values to Rapyd This commit also include a small update for the previos work made for [3ds Gateway Specific](#4876) Unit test ------------------------- Finished in 0.183111 seconds. 29 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notificationsomissions, 0 notifications 100% passed 158.37 tests/s, 808.25 assertions/s Remote test ------------------------- Finished in 113.329864 seconds. 34 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed 0.30 tests/s, 0.86 assertions/s Rubocop ------------------------- 763 files inspected, no offenses detected
javierpedrozaing
pushed a commit
that referenced
this pull request
Sep 8, 2023
Description ------------------------- [SER-808](https://spreedly.atlassian.net/browse/SER-808) This commit validate if the cvv in order to don't allow send empty values to Rapyd This commit also include a small update for the previos work made for [3ds Gateway Specific](#4876) Unit test ------------------------- Finished in 0.183111 seconds. 29 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notificationsomissions, 0 notifications 100% passed 158.37 tests/s, 808.25 assertions/s Remote test ------------------------- Finished in 113.329864 seconds. 34 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed 0.30 tests/s, 0.86 assertions/s Rubocop ------------------------- 763 files inspected, no offenses detected
javierpedrozaing
pushed a commit
that referenced
this pull request
Sep 8, 2023
Description ------------------------- [SER-808](https://spreedly.atlassian.net/browse/SER-808) This commit validate if the cvv in order to don't allow send empty values to Rapyd This commit also include a small update for the previos work made for [3ds Gateway Specific](#4876) Unit test ------------------------- Finished in 0.183111 seconds. 29 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notificationsomissions, 0 notifications 100% passed 158.37 tests/s, 808.25 assertions/s Remote test ------------------------- Finished in 113.329864 seconds. 34 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed 0.30 tests/s, 0.86 assertions/s Rubocop ------------------------- 763 files inspected, no offenses detected
javierpedrozaing
pushed a commit
that referenced
this pull request
Sep 8, 2023
Description ------------------------- [SER-808](https://spreedly.atlassian.net/browse/SER-808) This commit validate if the cvv in order to don't allow send empty values to Rapyd This commit also include a small update for the previos work made for [3ds Gateway Specific](#4876) Unit test ------------------------- Finished in 0.183111 seconds. 29 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notificationsomissions, 0 notifications 100% passed 158.37 tests/s, 808.25 assertions/s Remote test ------------------------- Finished in 113.329864 seconds. 34 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed 0.30 tests/s, 0.86 assertions/s Rubocop ------------------------- 763 files inspected, no offenses detected
naashton
pushed a commit
that referenced
this pull request
Sep 12, 2023
Description ------------------------- [SER-808](https://spreedly.atlassian.net/browse/SER-808) This commit validate if the cvv in order to don't allow send empty values to Rapyd This commit also include a small update for the previos work made for [3ds Gateway Specific](#4876) Unit test ------------------------- Finished in 0.183111 seconds. 29 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notificationsomissions, 0 notifications 100% passed 158.37 tests/s, 808.25 assertions/s Remote test ------------------------- Finished in 113.329864 seconds. 34 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed 0.30 tests/s, 0.86 assertions/s Rubocop ------------------------- 763 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit only add a couple of test to be sure that we are sending the three_d_required field as a GSF in order to perform a 3DS gateway specific in Rapyd.
SER-734
Unit test
Finished in 0.076246 seconds.
27 tests, 139 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
354.12 tests/s, 1823.05 assertions/s
Remote test
Finished in 113.329864 seconds.
34 tests, 98 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed
0.30 tests/s, 0.86 assertions/s
Rubocop
763 files inspected, no offenses detected