Adyen: Add payout endpoint #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
force-pushed
the
adyen_payouts
branch
2 times, most recently
from
c52926e
to
80a939c
Compare
almalee24
commented
Sep 15, 2023
| @@ -688,6 +720,23 @@ def add_3ds2_authenticated_data(post, options) | |||
| } | |||
| end | |||
|
|
|||
| def add_fund_source(post, options) | |||
| return unless fund_source = options[:fund_source] | |||
There was a problem hiding this comment.
The also have a card object but wasn't sure that we want customers to send us card info like this
curiousepic
approved these changes
Sep 18, 2023
| post[:selectedBrand] = options[:selected_brand] if options[:selected_brand] | ||
| post[:selectedBrand] ||= NETWORK_TOKENIZATION_CARD_SOURCE[payment.source.to_s] if payment.is_a?(NetworkTokenizationCreditCard) | ||
| post[:deliveryDate] = options[:delivery_date] if options[:delivery_date] | ||
| post[:merchantOrderReference] = options[:merchant_order_reference] if options[:merchant_order_reference] | ||
| post[:captureDelayHours] = options[:capture_delay_hours] if options[:capture_delay_hours] | ||
| post[:deviceFingerprint] = options[:device_fingerprint] if options[:device_fingerprint] | ||
| post[:shopperIP] = options[:ip] if options[:ip] | ||
| post[:shopperIP] = options[:shopper_ip] if options[:shopper_ip] |
There was a problem hiding this comment.
Are both of these lines meant to assign shopperIP? If so, is there a way to make this more concise?
There was a problem hiding this comment.
Yeah, idk why it was originally done like that. I'll update it
There was a problem hiding this comment.
Nice! I didn't realize that was existing code that had moved. My bad 🙃
almalee24
force-pushed
the
adyen_payouts
branch
from
80a939c
to
e07b267
Compare
kylene-spreedly
approved these changes
Sep 19, 2023
Remote: 137 tests, 453 assertions, 11 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.9708% passed Unit: 111 tests, 585 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
almalee24
force-pushed
the
adyen_payouts
branch
from
e07b267
to
19d0479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote:
137 tests, 453 assertions, 11 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.9708% passed
Unit:
111 tests, 585 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed