XpayGateway: initia Setup #4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavyblade
reviewed
Sep 13, 2023
There was a problem hiding this comment.
@javierpedrozaing done with the review, left some general comments and a couple of warnings.
javierpedrozaing
force-pushed
the
SER-763_Xpay_gateway_initial_setup
branch
2 times, most recently
from
0fb35c1
to
1a10b8d
Compare
Heavyblade
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Looks pretty much OK @javierpedrozaing, left couple coments
javierpedrozaing
force-pushed
the
SER-763_Xpay_gateway_initial_setup
branch
from
1a10b8d
to
d630de3
Compare
naashton
force-pushed
the
SER-763_Xpay_gateway_initial_setup
branch
from
d630de3
to
4356631
Compare
Description ------------------------- [SER-763](https://spreedly.atlassian.net/browse/SER-763) This commit add the initial setup for the new Xpay gateway Unit test ------------------------- Finished in 0.557754 seconds. 2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 3.59 tests/s, 7.17 assertions/s Remote test ------------------------- Finished in 0.557754 seconds. 2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 3.59 tests/s, 7.17 assertions/s Rubocop ------------------------- 769 files inspected, no offenses detected
naashton
force-pushed
the
SER-763_Xpay_gateway_initial_setup
branch
from
4356631
to
a33a5c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SER-763
This commit add the initial setup for the new Xpay gateway
Unit test
Finished in 0.557754 seconds.
2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
3.59 tests/s, 7.17 assertions/s
Remote test
Finished in 0.557754 seconds.
2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
3.59 tests/s, 7.17 assertions/s
Rubocop
769 files inspected, no offenses detected