Ogone: Fix signature calulcation for blank fields #4963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavyblade
force-pushed
the
SER-965_fixing_signature_calulcation_for_ogone
branch
from
7ddc191
to
445f34f
Compare
naashton
force-pushed
the
SER-965_fixing_signature_calulcation_for_ogone
branch
from
445f34f
to
cad0cfc
Compare
Summary: ------------------------------ Add changes to deal with ogone signature when there are empty fields on the passed params [SER-965](https://spreedly.atlassian.net/browse/SER-965) Remote Test: ------------------------------ Finished in 135.715931 seconds. 33 tests, 138 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.9697% passed Unit Tests: ------------------------------ Finished in 38.938916 seconds. 5733 tests, 78693 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 784 files inspected, no offenses detected
naashton
force-pushed
the
SER-965_fixing_signature_calulcation_for_ogone
branch
from
cad0cfc
to
211e4d8
Compare
naashton
approved these changes
Nov 21, 2023
naashton
approved these changes
Nov 21, 2023
| @@ -460,7 +460,7 @@ def calculate_signature(signed_parameters, algorithm, secret) | |||
| raise "Unknown signature algorithm #{algorithm}" | |||
| end | |||
|
|
|||
| filtered_params = signed_parameters.compact | |||
| filtered_params = signed_parameters.reject { |_k, v| v.nil? || v == '' } | |||
There was a problem hiding this comment.
Nice! This reject method is new to me, but this is pretty clever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add changes to deal with ogone signature when there are empty fields on the passed params
SER-965
Tests
Remote Test:
Finished in 135.715931 seconds.
33 tests, 138 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
96.9697% passed
Unit Tests:
Finished in 38.938916 seconds.
5733 tests, 78693 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
RuboCop:
784 files inspected, no offenses detected