SagePayForm: Use valid delimiter in VendorTxCode

[aprofeit]

Problem

I had a creepy feeling after we merged e9be51c. I checked the SagePay docs and realized ; is not a valid character for VendorTxCode. Close one.

Changes

Use - instead.

Review

@ThereExistsX @ivanfer

[ivanfer]

what's the difference between this and split?

[aprofeit]

If you have a string like abc-123-def split doesn't have the capability of returning abc-123.

irb(main):003:0> "abc-123-def".split('-')
=> ["abc", "123", "def"]
irb(main):004:0> "abc-123-def".split('-', 1)
=> ["abc-123-def"]
irb(main):005:0> "abc-123-def".split('-', 2)
=> ["abc", "123-def"]
irb(main):006:0> "abc-123-def".split('-', 3)
=> ["abc", "123", "def"]
irb(main):007:0> "abc-123-def".rpartition('-')
=> ["abc-123", "-", "def"]
irb(main):008:0>

[ivanfer]

nice catch - 🌴

[ThereExistsX]

I was going to mention that you shouldn't split on - for that very reason, good save. You'll need to update the helper tests though.

[aprofeit]

In the tests I have order-28-1234 as the VendorTxCode on the test requests just to make sure it splits it correctly. Fixed tests, will be green now.