Send Billing Address for Universal Gateways #190
Conversation
| @@ -112,6 +112,30 @@ def test_shipping_address_fields | |||
| assert_field 'x_customer_shipping_phone', '(416) 123-4567' | |||
| end | |||
|
|
|||
| def test_billing_address_fields | |||
| @helper.billing_address :first_name => 'John', | |||
| :last_name => 'Doe', | |||
There was a problem hiding this comment.
Stylewise, space is off here.
There was a problem hiding this comment.
@aprofeit : Should be fixed now.
|
What does this actually change? Is this now included in the request we send to the offsite payment gateway? |
|
If I test this out in the universal gateway simulator, will these new fields show up? |
|
@aprofeit : Yep, you can pull down the branch and test it using any universal gateway you have including the Bogus Gateway. |
ThereExistsX
force-pushed
the
send-billing-address
branch
from
b815f89
to
c6465d6
Compare
|
I think I may be missing something, how does this affect the bogus gateway? |
|
Looks like everything shows up correctly in offsite simulator |
|
Nice job -- we'll need to notify the gateways before merging this change though. |
Do we really? These are just additional fields we're sending them, shouldn't affect them, right? |
|
@aprofeit in theory yes, but good practice to give them a heads up just in case no? ie. they might have a check for number of fields |
|
@andrewpaliga -- Just let me know when this is good to ship! |
I guess it's possible, but would be pretty weird. Your call. |
|
It doesn't break our code (@razorpay), but I'd still have liked a heads-up for this change. |
Allow universal gateways to send their billing address as well as their shipping address.
Attn:
@aprofeit @andrewpaliga @girasquid