[WorldPay] Use multiple address fields #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi3r
reviewed
Jan 4, 2018
| :city => 'town', | ||
| :state => 'region', | ||
| :zip => 'postcode', | ||
| :country => 'country' |
There was a problem hiding this comment.
Before it was doing lookup_country_code(params[:country]). I can't remember what we set to country but we have to ensure it's the ISO country code and not the country name.
There was a problem hiding this comment.
Just checked, we should be sending the country_code alright!
There was a problem hiding this comment.
The add_address helper takes care of this so it's all good 👍
pi3r
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current mapping for WorldPay concatenates
address1,address2,city&stateinto one field "address".That caused address to be displayed weirdly on WorldPay's end.
WorldPay does support sending address fields separately. WorldPay Specification
This PR removes the need to concatenate address data.