Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added progress indicator to command line interface #99

Merged
merged 3 commits into from
Nov 19, 2018

Conversation

Bioruebe
Copy link
Contributor

This is a change made to the command line version of lessmsi for integration into Universal Extractor. It adds a progress display, written to stdout for each file extracted.

Example:

Extracting '<file.msi>' to '<folder>'.
1/296   license.txt
2/296   readme.txt
...

I think it's nicer for the user to see how far the extraction progress went, so you might want to add the change to the official repository. But it's just a suggestion :)

This is a change made for Universal Extractor to provide the progress written to stdout for each file extracted.
@activescott
Copy link
Owner

@Bioruebe Thanks. I agree it sounds better for the user. The build is failing now though on AppVeyor (appears to be a compile error). Can you please look at that?

@Bioruebe
Copy link
Contributor Author

Oh, I completely forgot about this problem after giving up the first time ;)

Finally, here is a fixed version. It turned out to be a problem related to the way the stdout is read inside the test cases. For msi installers with many files the progress indicator caused an internal buffer to fill up and block the whole process. More information

@activescott activescott merged commit a1143a1 into activescott:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants