allow parent data containers to be accessed from child scopes #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
force-pushed
the
feat/data-cascade
branch
from
14c148a
to
9b1aa99
Compare
robjtede
commented
May 3, 2020
robjtede
commented
May 3, 2020
| inner.app_data = self.data.clone(); | ||
| inner.app_data.push(self.data.clone()); |
There was a problem hiding this comment.
I'm not 100% clear on the purpose and lifecycle of the request pool so not sure if this should be .app_data.push(...) or .app_data = tiny_vec![...].
robjtede
force-pushed
the
feat/data-cascade
branch
from
9b1aa99
to
5e407cc
Compare
robjtede
force-pushed
the
feat/data-cascade
branch
from
5e407cc
to
f545035
Compare
JohnTitor
approved these changes
May 8, 2020
robjtede
force-pushed
the
feat/data-cascade
branch
from
f545035
to
879cad9
Compare
This was referenced Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceRequest::set_data_containernow adds to an array ofRc<Extensions>s and lookups reverse iterate to find the closest app data of that type.Adds the
tinyvecdependency to keep a small set of references to data containers on the stack, up to 4 data containers, which should cover most use cases optimally.