Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix non-empty body of http2 HEAD response #2920

Merged
merged 4 commits into from
Jan 21, 2023
Merged

fix non-empty body of http2 HEAD response #2920

merged 4 commits into from
Jan 21, 2023

Conversation

cumtyc
Copy link
Contributor

@cumtyc cumtyc commented Oct 25, 2022 •
edited by robjtede
Loading

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

The body of http2 HEAD response was non-empty, test h2_head_empty works because awc drop the body in the client.

@robjtede robjtede added this to the actix-web v4.3 milestone Jan 3, 2023
@robjtede robjtede added A-http project: actix-http B-semver-patch labels Jan 3, 2023
robjtede
robjtede approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍🏻

@robjtede robjtede enabled auto-merge (squash) January 21, 2023 00:16
@robjtede robjtede merged commit 2f0b8a2 into actix:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-http project: actix-http B-semver-patch
Projects
None yet
Milestone
actix-web v4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@cumtyc @robjtede