Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookie dependency to 0.18 #3336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ffreddow
Copy link

@ffreddow ffreddow commented Apr 17, 2024

PR Type

Update dependency

PR_TYPE

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Update the cookie dependency to 0.18 since increasingly more browsers require the "Partitioned" attribute to be able to send cross-site-requests containing cookies. It was added to the cookie crate with version 0.18.1.

The changes in the cookie crate introduce breaking changes in the creation of cookies.

@robjtede robjtede added this to the actix-web v5.0 milestone Jun 7, 2024
@robjtede robjtede added B-semver-major breaking change requiring a major version bump A-awc project: awc A-web project: actix-web labels Jun 7, 2024
@robjtede
Copy link
Member

robjtede commented Jun 9, 2024

It should be possible to use cookie v0.18 manually if you desperately need the experimental Partitioned flag.

I want to point out that cookie v0.18 is just one option for the v5.0 upgrade path. Migrating to biscotti is also something I'd like to try out before making any decisions.

@ffreddow
Copy link
Author

ffreddow commented Jun 9, 2024

Yea for us this is not urgent. Currently we workaround by adding the partitioned flag manually which works just perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-awc project: awc A-web project: actix-web B-semver-major breaking change requiring a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants