Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svg files not being compressed #3486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Degubi
Copy link

@Degubi Degubi commented Oct 16, 2024

PR Type

Bug Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

#3075 removed compression for image & video files, because they usually come pre-compressed.
SVG (image/svg+xml) files are exceptions (IMO), because they're text based, so they could benefit from being served as compressed assets.

Note 1: I wasn't sure whether to add a test or not.
Note 2: I wasn't able to test this change because I was getting a wall of seemingly unrelated 'unresolved imports' errors in my project after switching to my fork in the Cargo.toml.

@robjtede robjtede added A-files project: actix-files B-semver-patch A-web project: actix-web and removed A-files project: actix-files labels Oct 16, 2024
@Degubi
Copy link
Author

Degubi commented Nov 6, 2024

Not really sure about the 'Linux / msrv actix-files tests::test_head_content_length_headers' test failure, because afaict I didn't touch anything that could cause that test to fail.

About the 'public-api-diff' I saw that another PR was failing with the same error message as this PR:

This version of `cargo public-api` requires at least:
    nightly-2024-10-18
Ensure your nightly toolchain is up to date with:
    rustup install nightly --profile minimal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants