Wake Future when EOF is received #3492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a TCP FIN is received, the Future needs to be awakened. Without this, it is not possible to detect a connection closure in end-user applications.
asonix
approved these changes
Nov 9, 2024
| @@ -5,6 +5,7 @@ | |||
| ### Added | |||
|
|
|||
| - Add `header::CLEAR_SITE_DATA` constant. | |||
| - Fix bug which prevents end-users from discovering when the remote peer has closed its side of the TCP connection. | |||
There was a problem hiding this comment.
This should probably be in a new ### Fixed section rather than in "Added"
| @@ -205,6 +205,7 @@ impl Inner { | |||
| #[inline] | |||
| fn feed_eof(&mut self) { | |||
| self.eof = true; | |||
| self.wake(); | |||
There was a problem hiding this comment.
I think this makes sense. I can imagine a scenario where Payload is polled before EOF comes in, and then EOF comes in and Payload is not woken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug fix
PR Checklist
Overview
When a TCP FIN is received, the Future needs to be awakened. Without this, it is not possible to detect a connection closure in end-user applications.
Relates to: #3093