Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Vector4 classes improvement #865

Merged
merged 34 commits into from
Sep 28, 2021
Merged

Feat: Vector4 classes improvement #865

merged 34 commits into from
Sep 28, 2021

Conversation

emadurandal
Copy link
Collaborator

@emadurandal emadurandal commented Sep 26, 2021

Constructors of Vector classes now accept a Float32Array instance only. Use Vector[2|3|4]@from**** static methods instead.

const vec_before = new Rn.Vector4(0, 0, 0, 1); // obsoleted

const vec_current = Rn.Vector4.fromCopyArray([0, 0, 0, 1]); // Use this style from now on

┆Issue is synchronized with this Wrike Item

@emadurandal emadurandal force-pushed the feat/math branch 4 times, most recently from 6187ad9 to 36b3e4d Compare September 26, 2021 15:44
Add a check to "this.__htmlImageElement" since it was undefined.
This.__htmlImageElement!.width is undefined, so change it to use a pre-set value.
@emadurandal emadurandal force-pushed the feat/math branch 4 times, most recently from 7aa7211 to 5c200cc Compare September 26, 2021 17:04
@emadurandal emadurandal marked this pull request as ready for review September 28, 2021 05:04
@emadurandal emadurandal changed the title Feat: math classes improvement Feat: Vector4 classes improvement Sep 28, 2021
@emadurandal emadurandal merged commit 51d9b91 into master Sep 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/math branch September 28, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants