-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Vector4 classes improvement #865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadurandal
force-pushed
the
feat/math
branch
4 times, most recently
from
September 26, 2021 15:44
6187ad9
to
36b3e4d
Compare
Add a check to "this.__htmlImageElement" since it was undefined. This.__htmlImageElement!.width is undefined, so change it to use a pre-set value.
emadurandal
force-pushed
the
feat/math
branch
4 times, most recently
from
September 26, 2021 17:04
7aa7211
to
5c200cc
Compare
fix: glTFExporter error
chore: add a comment for byteStride of Accessor
…ctor2 static methods to Vector4
emadurandal
force-pushed
the
feat/math
branch
from
September 28, 2021 04:55
5c200cc
to
1ddd38f
Compare
emadurandal
changed the title
Feat: math classes improvement
Feat: Vector4 classes improvement
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructors of Vector classes now accept a Float32Array instance only. Use Vector[2|3|4]@from**** static methods instead.
┆Issue is synchronized with this Wrike Item