Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove using namespace in Detray plugin header #3616

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: Remove using namespace in Detray plugin header #3616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Examples/Python/src/Geometry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,8 @@ void addExperimentalGeometry(Context& ctx) {
});

// Portal definition
py::class_<Portal, std::shared_ptr<Portal>>(m, "Portal");
py::class_<Experimental::Portal, std::shared_ptr<Experimental::Portal>>(
m, "Portal");

{
// The surface hierarchy map
Expand Down
5 changes: 2 additions & 3 deletions Plugins/Detray/include/Acts/Plugins/Detray/DetrayConverter.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@

namespace Acts {

using namespace Experimental;

class DetrayConverter {
public:
/// Detray conversion options
Expand All @@ -49,7 +47,8 @@ class DetrayConverter {
///
/// @returns a detector of requested return type
template <typename detector_t = DetrayHostDetector>
detector_t convert(const GeometryContext& gctx, const Detector& detector,
detector_t convert(const GeometryContext& gctx,
const Experimental::Detector& detector,
vecmem::memory_resource& mr, const Options& options) {
// The building cache object
DetrayConversionUtils::GeometryIdCache geoIdCache;
Expand Down
Loading