🐛 (reports) deleting custom report should remove it from the dashboard

Closes #3354
actualbudget · Sep 19, 2024 · 7525349 · 7525349
1 parent 5e12d40
commit 7525349
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx b/packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx
@@ -9,6 +9,7 @@ import { type CustomReportEntity } from 'loot-core/types/models/reports';
 
 import { useAccounts } from '../../../hooks/useAccounts';
 import { useCategories } from '../../../hooks/useCategories';
+import { useFeatureFlag } from '../../../hooks/useFeatureFlag';
 import { usePayees } from '../../../hooks/usePayees';
 import { useSyncedPref } from '../../../hooks/useSyncedPref';
 import { SvgExclamationSolid } from '../../../icons/v1';
@@ -35,9 +36,15 @@ export function CustomReportListCards({
   report,
   onRemove,
 }: CustomReportListCardsProps) {
+  const isDashboardsFeatureEnabled = useFeatureFlag('dashboards');
+
   // It's possible for a dashboard to reference a non-existing
   // custom report
   if (!report) {
+    if (!isDashboardsFeatureEnabled) {
+      return null;
+    }
+
     return (
       <MissingReportCard isEditing={isEditing} onRemove={onRemove}>
         This custom report has been deleted.

diff --git a/upcoming-release-notes/3469.md b/upcoming-release-notes/3469.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MatissJanis]
+---
+
+Reports - deleting custom reports should remove the widget from the dashboard.