Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CSV duplicate matching no longer showing in the import window. #3416

Closed
2 tasks done
youngcw opened this issue Sep 10, 2024 · 1 comment · Fixed by #3456
Closed
2 tasks done

[Bug]: CSV duplicate matching no longer showing in the import window. #3416

youngcw opened this issue Sep 10, 2024 · 1 comment · Fixed by #3456
Labels
bug Something isn't working regression This bug appeared after a recent release and needs to be fixed before the next release
Milestone

Comments

@youngcw
Copy link
Member

youngcw commented Sep 10, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

The CSV importer is supposed to show matching transactions so the user can decide to force import or allow matching and deduplication. That is no longer happening in the current version. It quit happening somewhere between 24.8 and 24.9.

The quickest way to test is to either use a existing csv and import it twice, or to make an export of a test budget account, then to reimport it and see that its not matching any of the transactions. Compare against the deploy for v24.8 to see the difference. https://deploy-preview-3179.demo.actualbudget.org/

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

@youngcw youngcw added bug Something isn't working regression This bug appeared after a recent release and needs to be fixed before the next release labels Sep 10, 2024
@MatissJanis MatissJanis added this to the v24.10.0 milestone Sep 14, 2024
@UnderKoen
Copy link
Member

I have done some debugging and found the fix/problem before #3413 . In #3234 they use the wrong property and incorrect type check.

For #3413 I suspect that the problem is with rerenders. When trying to import a CSV it keeps refreshing and doing weird stuff

UnderKoen added a commit to UnderKoen/actual that referenced this issue Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression This bug appeared after a recent release and needs to be fixed before the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants