Fix electron export issue #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats - desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats - loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
|
This seems like a reasonable approach. You should be able to use a function like |
|
I went with uuid in the end because i don't want to drag in another npm pacakge for |
j-f1
approved these changes
Jul 2, 2023
trafico-bot
bot
added
✨ Merged
TomAFrench
added a commit
to TomAFrench/actual
that referenced
this pull request
Jul 4, 2023
* master: (34 commits) chore: add types to `crdt` package (actualbudget#1076) Fix layout of the management app with the demo bar in place (actualbudget#1267) ♻️ (select) removing 2x usages of the Select component (actualbudget#1259) Fix transaction list scrolling behavior (actualbudget#1260) 🐛 fix link-schedule option in transaction table (actualbudget#1250) cleared/uncleared background update (actualbudget#1265) Fix calculation of how many table rows to render (actualbudget#1262) ♻️ moving more components out of common.tsx (actualbudget#1257) ♻️ moving some components from common.tsx to separate files (actualbudget#1248) 🐛 fix toggling of balances in all-accounts view (actualbudget#1252) 🐛 (mobile) reduce the size of account cards (actualbudget#1247) Fix electron export issue (actualbudget#1242) Saved Filters Page (actualbudget#1122) 🔧 cancel previous CI runs if a new push is made (actualbudget#1251) .gitattributes Check line endings for tsx files (actualbudget#1246) Fix importing transfers from YNAB4/5 (actualbudget#1224) Auto-close the local/nordigen picker modal after creating an account (actualbudget#1219) Run “Handle completed feature requests” in pull_request_target (actualbudget#1243) Add electron options to bug-report.yml (actualbudget#1239) Add onClick handlers to the schedule and transaction icons in the transaction list (actualbudget#1228) ...
22 tasks
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1238
If we are happy with this approach, which I don't love, I'll tidy it up a bit first, check the file doesn't exist, use a random(er) name, wrap it in a functon etc.
Basically the
better-sqliteserializefunction can't be used, as I guess under the surface its allocating a chunk of memory in C.I tried to wrap all this logic inside the
exportDatabasefunction in/server/sqlite/index.electron.tsbut I had a lot of problems trying to importfsthere if anyone can give advice.