Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 (import) fix csv import checkboxes not working #3478

Merged
merged 1 commit into from
Sep 22, 2024
Merged

🐛 (import) fix csv import checkboxes not working #3478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions packages/desktop-client/src/components/modals/ImportTransactionsModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,6 @@ export function ImportTransactionsModal({ options }) {
const [flipAmount, setFlipAmount] = useState(false);
const [multiplierEnabled, setMultiplierEnabled] = useState(false);
const [reconcile, setReconcile] = useState(true);
const [previewTrigger, setPreviewTrigger] = useState(0);
const { accountId, categories, onImported } = options;

// This cannot be set after parsing the file, because changing it
Expand Down Expand Up @@ -1368,7 +1367,7 @@ export function ImportTransactionsModal({ options }) {
close();
}

const runImportPreviewCallback = useCallback(async () => {
const runImportPreview = useCallback(async () => {
const transactionPreview = await getImportPreview(
transactions,
filetype,
Expand Down Expand Up @@ -1397,14 +1396,6 @@ export function ImportTransactionsModal({ options }) {
multiplierAmount,
]);

useEffect(() => {
runImportPreviewCallback();
}, [previewTrigger, runImportPreviewCallback]);

function runImportPreview() {
setPreviewTrigger(value => value + 1);
}

const headers = [
{ name: 'Date', width: 200 },
{ name: 'Payee', width: 'flex' },
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/3478.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [MatissJanis]
---

CSV import - fix checkboxes not working.
Loading